Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Aliucord on GrapheneOS by adding VmSafeMode #73

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Fix Aliucord on GrapheneOS by adding VmSafeMode #73

merged 1 commit into from
Jun 16, 2024

Conversation

Enovale
Copy link
Contributor

@Enovale Enovale commented Jun 14, 2024

This patch fixes AOT preventing Aliucord on GrapheneOS to work properly.

Also, while working on the fix I cleaned up a few things:

  • I noticed when viewing the patched manifest in MiXplorer, the android namespace had some autogenerated name so I fixed that.
  • The vmSafeMode attribute requires specifying the resourceId to work, so I figured the other attributes should also have their resourceIds set, because I would assume that would make it more correct. Please feel free to test and tell me if that assumption was incorrect.

@Enovale
Copy link
Contributor Author

Enovale commented Jun 14, 2024

This should resolve Aliucord/Aliucord#427

@Enovale
Copy link
Contributor Author

Enovale commented Jun 16, 2024

Testers can try a build here: https://github.com/Enovale/AliucordManager/actions/runs/9533261398/artifacts/1605554213

@rushiiMachine rushiiMachine merged commit 6b3da4f into Aliucord:main Jun 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushiiMachine rushiiMachine rushiiMachine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Enovale @rushiiMachine