Fix for gamespeak breaking after quitting demo mid-hello #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k breaks gamespeak & causes special case crashes
MrSapps
reviewed
May 17, 2022
| @@ -342,6 +342,10 @@ EXPORT void CC Quicksave_LoadFromMemory_4C95A0(Quicksave* quicksaveData) | |||
| 0, | |||
| 1); | |||
| gMap_5C3030.field_8_force_load = 1; | |||
|
|
|||
| #if ORIGINAL_GAME_FIXES | |||
| sIsMudStandingUp_5C3018 = 0; | |||
There was a problem hiding this comment.
should this not actually be part of the quick save data structure? it seems like something that should be persisted?
There was a problem hiding this comment.
Ideally, probably yes, it didn't seem to have any negative side effects to do it this way during my tests, and I wasn't sure if I could modify quicksave/quickload data without messing with actual save files as well, as it seemed to read the quicksave data from the save file if I'm not mistaken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #907 AE OG Bug - Interrupting demo during Abe gamespeak breaks gamespeak & causes special case crashes by unsetting sIsMudStandingUp_5C3018 when a demo is ended by a keypress.