config: introduce use_exact_fp option #1129
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration option is useful for returning the exact fp from FloatType::fromFloat, ignoring NaN, and is required by Minotaur [https://arxiv.org/abs/2306.00229] to synthesize correctly. use_exact_fp is turned off by default, and should pose no correctness issue when turned on.
Contributor
Author
|
I have checked that when this is applied along with #1128, all tests in Minotaur pass. |
Member
|
This is not correct. Verification done by disabling the whole NaN stuff cannot be relied upon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration option is useful for returning the exact fp from FloatType::fromFloat, ignoring NaN, and is required by Minotaur [https://arxiv.org/abs/2306.00229] to synthesize correctly. use_exact_fp is turned off by default, and should pose no correctness issue when turned on.