Skip to content

Commit

Permalink
test: skip the flay case
Browse files Browse the repository at this point in the history
When the init process in a container exits, the pouchcontainer daemon
will handle the cleanup job, such as update status code, delete the
containerd's task/container record. The action is handled in the
goroutine. Since pouchcontainer doesn't lock the whole container, when
the status has been updated from `running` into `stopped`, the
containerd's task/container records are not removed by the cleanup job.
if the user wants to use `wait` command to make sure that cleanup job
has been done, it will fail because the status is updated first.

The flaky case is running on this case. We can run it until we have
better solutions to make the status notification more stable.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
  • Loading branch information
fuweid authored and HusterWan committed Jan 24, 2019
1 parent 81ae43f commit ba2ebf7
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/z_cli_daemon_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,8 @@ func (suite *PouchDaemonSuite) TestDaemonWithMultiRuntimes(c *check.C) {
// when container is stopped and then pouchd restarts, the restore logic should
// initialize the existing container IO settings even though they are not alive.
func (suite *PouchDaemonSuite) TestRestartStoppedContainerAfterDaemonRestart(c *check.C) {
c.Skip("The wait command can't guarantee container cleanup job can be done before api return")

cfgFile := filepath.Join("/tmp", c.TestName())
c.Assert(CreateConfigFile(cfgFile, nil), check.IsNil)
defer os.RemoveAll(cfgFile)
Expand Down

0 comments on commit ba2ebf7

Please sign in to comment.