Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[help wanted] add unit-test for DetachVolume #1761

Closed
starnop opened this issue Jul 21, 2018 · 0 comments · Fixed by #1824
Closed

[help wanted] add unit-test for DetachVolume #1761

starnop opened this issue Jul 21, 2018 · 0 comments · Fixed by #1824
Labels
areas/storage areas/test

Comments

@starnop
Copy link
Contributor

starnop commented Jul 21, 2018

Ⅰ. Issue Description

Add unit-test for Volume Core's DetachVolume method which locate on storage/volume/core.go.

Ⅱ. Describe what happened

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

please "Baiji" developer refer to this issue in your PR for the convenience for us to count your score.

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
This was referenced Jul 23, 2018
Closed
Closed
@btlcmr0702 btlcmr0702 mentioned this issue Jul 24, 2018
Closed
@panzaiyu panzaiyu mentioned this issue Jul 24, 2018
Merged
@SeaRise SeaRise mentioned this issue Jul 24, 2018
Closed
@lzpawell lzpawell mentioned this issue Jul 24, 2018
Closed
@SeaRise SeaRise mentioned this issue Jul 24, 2018
Closed
@Inoria-cn Inoria-cn mentioned this issue Jul 24, 2018
Closed
@SkyScraperTwc SkyScraperTwc mentioned this issue Jul 24, 2018
Closed
@YitianChen1996 YitianChen1996 mentioned this issue Jul 24, 2018
Closed
@yannanyue yannanyue mentioned this issue Jul 24, 2018
Closed
@sunzeyucmu sunzeyucmu mentioned this issue Jul 24, 2018
Closed
@zhengshiqiang47 zhengshiqiang47 mentioned this issue Jul 24, 2018
Closed
jiapengcs added a commit to jiapengcs/pouch that referenced this issue Jul 24, 2018
@jiapengcs
fixes AliyunContainerService#1761 baiji-group=264-3
010e06e
@jiapengcs jiapengcs mentioned this issue Jul 24, 2018
Closed
allencloud added a commit that referenced this issue Jul 24, 2018
@allencloud
Merge pull request #1824 from panzaiyu/fix-issue-1761
8272bb3 
fix issue #1761 baiji-group 264-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
areas/storage areas/test
Projects
None yet
Milestone
No milestone
2 participants
@starnop @pouchrobot