Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] pouch support kubernetes runtime class #2314

Closed
fanux opened this issue Oct 16, 2018 · 7 comments · Fixed by #2325
Closed

[feature request] pouch support kubernetes runtime class #2314

fanux opened this issue Oct 16, 2018 · 7 comments · Fixed by #2325
Assignees
Labels
areas/orchestration kind/feature kind/feature-request This is a feature request from community for PouchContainer

Comments

@fanux
Copy link
Contributor

fanux commented Oct 16, 2018

About kubernetes runtime class

Support runtime class so the user can select runtime in one kubernetes cluster.

kind: RuntimeClass
apiVersion: node.k8s.io/v1alpha1
metadata:
    name: pouch
spec:
    runtimeHandler: pouch
----
# provides the default sandbox runtime when users don't care about which they're getting.
kind: RuntimeClass
apiVersion: node.k8s.io/v1alpha1
metadata:
  name: sandboxed
spec:
  runtimeHandler: gvisor

for more details about runtime class, we could refer to https://kubernetes.io/docs/concepts/containers/runtime-class/

@pouchrobot pouchrobot added areas/orchestration kind/feature kind/feature-request This is a feature request from community for PouchContainer labels Oct 16, 2018
@allencloud
Copy link
Collaborator

Assigned to @starnop to take a look at this.

@starnop
Copy link
Contributor

starnop commented Oct 16, 2018

@fanux @allencloud Thank you for your request, We've actually supported selecting the container runtime to run a pod so far but only for runc and runv. For details, please refer to #1593

In fact, RuntimeClass is an alpha feature, and we will keep following up on this , get more info refers to
https://github.com/kubernetes/community/blob/master/keps/sig-node/0014-runtime-class.md

@allencloud
Copy link
Collaborator

@starnop So, an alpha feature of Kubernetes will not bring into PouchContainer, right?
And we will keep an eye on this and make decision whether to introduce that into Pouch, right?

@fanux Could the following way meet your demand?

upported selecting the container runtime to run a pod so far but only for runc and runv

@fanux
Copy link
Contributor Author

fanux commented Oct 17, 2018

Pouch runc runv meet our demand now, But in the future, we also want to run pouch docker or gvisor in one kubernetes cluster.

@starnop
Copy link
Contributor

starnop commented Oct 17, 2018

I'm looking through the documentation and will support this feature ASAP.

@xiaoxubeii
Copy link
Contributor

@fanux @allencloud Thank you for your request, We've actually supported selecting the container runtime to run a pod so far but only for runc and runv. For details, please refer to #1593

In fact, RuntimeClass is an alpha feature, and we will keep following up on this , get more info refers to
https://github.com/kubernetes/community/blob/master/keps/sig-node/0014-runtime-class.md

My bad, you are right. RuntimeClass is CRI implementation dependent.

@allencloud
Copy link
Collaborator

Pouch runc runv meet our demand now, But in the future, we also want to run pouch docker or gvisor in one kubernetes cluster.

@fanux Reasonable. @starnop is looking at this and try to support. Maybe we could discuss further in dingtalk chat group. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/orchestration kind/feature kind/feature-request This is a feature request from community for PouchContainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants