-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: manual of container labels and annotaions under cri #2672
docs: manual of container labels and annotaions under cri #2672
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2672 +/- ##
==========================================
+ Coverage 69.34% 69.38% +0.04%
==========================================
Files 278 278
Lines 17428 17428
==========================================
+ Hits 12085 12093 +8
+ Misses 3994 3989 -5
+ Partials 1349 1346 -3
|
7852de9
to
a194f03
Compare
a194f03
to
19cab6e
Compare
19cab6e
to
7506b69
Compare
* [Make runtime choosing supported](#make-runtime-choosing-supported "Make runtime choosing supported") | ||
* [Make lxcfs configurable supported](#make-lxcfs-configurable-supported "Make lxcfs configurable supported") | ||
* [Pull Request](#pull-request "Pull Request") | ||
* [Runtime choosing](#runtime-choosing "Runtime choosing") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use annotations to support runtime choosing for legacy kubernetes. RuntimeHandler of kubernetes 1.12 is also supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that, I think we should add detailed instructions in this document.
< 1.12, suggest using annotation;
>= 1.12, use runtime class
In addition, we should have a plan whether to deprecate the annotation for future.
Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
7506b69
to
95e8b20
Compare
|
|
||
NOTES: The way to specify runtime using **KubernetesRuntime annotation is Deprecated**. It is recommended to use [RuntimeClass](https://v1-12.docs.kubernetes.io/docs/concepts/containers/runtime-class) which is an alpha feature for selecting the container runtime configuration to use to run a pod’s containers. | ||
NOTES: **Specify runtimes using `io.kubernetes.runtime` annotation is Deprecated**. It is recommended to use [RuntimeClass](https://v1-12.docs.kubernetes.io/docs/concepts/containers/runtime-class) which is an alpha feature for selecting the container runtime configuration to use to run a pod’s containers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RuntimeClass is a stable feature and the url is deprecated, could you help to fix them? Also there have a merge conflict, thanks to rebase it!
* [Pull Request](#pull-request "Pull Request") | ||
* [Runtime choosing](#runtime-choosing "Runtime choosing") | ||
* [LXCFS switcher](#lxcfs-switcher "LXCFS switcher") | ||
* [VM passthrough config](#vm-passthrough "VM passthrough config") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need set correctly markdown anchor point here and follows, e.g. VM passthrough config (#vm-passthrough-config "VM passthrough config") 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope you can fix these questions
Thank you for your contribution! because you don't response for a long time, I will close this PR and reopen another one. ❤️ |
Signed-off-by: zhuangqh zhuangqhc@gmail.com
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews