Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: manual of container labels and annotaions under cri #3035

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

cxz66666
Copy link
Collaborator

@cxz66666 cxz66666 commented Jul 18, 2022

Ⅰ. Describe what this PR did

similar as #2672

  1. add missing document for vm pass through config annotation
  2. explain the container label rule under CRI implement

Ⅱ. Does this pull request fix one issue?

No

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

just update doc.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2022

CLA assistant check
All committers have signed the CLA.

1. add missing document for vm pass through config annotation
2. explain the container label rule under CRI implement
@rudyfly
Copy link
Collaborator

rudyfly commented Jul 20, 2022

LGTM

@rudyfly rudyfly merged commit 27acb46 into AliyunContainerService:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants