Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] CRI support memory_swap #2698

Closed
wangforthinker opened this issue Jan 28, 2019 · 1 comment · Fixed by #2700
Closed

[feature request] CRI support memory_swap #2698

wangforthinker opened this issue Jan 28, 2019 · 1 comment · Fixed by #2700
Assignees
@zhuangqh
Labels
kind/feature kind/feature-request This is a feature request from community for PouchContainer

Comments

@wangforthinker
Copy link
Contributor

wangforthinker commented Jan 28, 2019 •
edited
Loading

Why you need it?

We want to set memory swap by CRI interface.

How it could be?

There are two suggestion.
Add a field of MemorySwap in LinuxContainerResources struct.
Define an annotation key such as memory_swap and transfer it by Annotations field.

Other related information
@pouchrobot pouchrobot added kind/feature kind/feature-request This is a feature request from community for PouchContainer labels Jan 28, 2019
@zhuangqh
Copy link
Contributor

good advise. Using annotation for extension fields to achieve the least break of CRI interface.

@wangforthinker wangforthinker mentioned this issue Jan 28, 2019
Merged
@weekly-digest weekly-digest bot mentioned this issue Feb 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhuangqh zhuangqh

Labels
kind/feature kind/feature-request This is a feature request from community for PouchContainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support memory swap by CRI wangforthinker/pouch
3 participants
@wangforthinker @zhuangqh @pouchrobot