-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support memory swap by CRI #2700
Merged
fuweid
merged 1 commit into
AliyunContainerService:master
from
wangforthinker:feature/cri-support-memoryswap
Jan 29, 2019
Merged
support memory swap by CRI #2700
fuweid
merged 1 commit into
AliyunContainerService:master
from
wangforthinker:feature/cri-support-memoryswap
Jan 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2700 +/- ##
==========================================
+ Coverage 67.53% 69.27% +1.73%
==========================================
Files 278 278
Lines 17409 17421 +12
==========================================
+ Hits 11758 12068 +310
+ Misses 4330 4033 -297
+ Partials 1321 1320 -1
|
zhuangqh
reviewed
Jan 29, 2019
wangforthinker
force-pushed
the
feature/cri-support-memoryswap
branch
from
January 29, 2019 02:54
2a8a014
to
c10af73
Compare
zhuangqh
reviewed
Jan 29, 2019
wangforthinker
force-pushed
the
feature/cri-support-memoryswap
branch
from
January 29, 2019 03:15
23575a6
to
7a6f364
Compare
zhuangqh
reviewed
Jan 29, 2019
wangforthinker
force-pushed
the
feature/cri-support-memoryswap
branch
from
January 29, 2019 03:23
93b6616
to
4e48a90
Compare
ping @zhuangqh |
zhuangqh
approved these changes
Jan 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fuweid
reviewed
Jan 29, 2019
Signed-off-by: allen.wang <allen.wq@alipay.com>
wangforthinker
force-pushed
the
feature/cri-support-memoryswap
branch
from
January 29, 2019 05:58
4e48a90
to
694a363
Compare
fuweid
reviewed
Jan 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: allen.wang allen.wq@alipay.com
Ⅰ. Describe what this PR did
Support to set memory swap by CRI interface. If set key resources.memory_swap in annotation, pouch will set it to container config.
Ⅱ. Does this pull request fix one issue?
Fix #2698.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
add testcase.
Ⅳ. Describe how to verify it
do it by testcase.
Ⅴ. Special notes for reviews