Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: we could create container with invalid name #2918

Closed
lang710 opened this issue Jun 20, 2019 · 0 comments
Closed

bug: we could create container with invalid name #2918

lang710 opened this issue Jun 20, 2019 · 0 comments
Labels
kind/bug This is bug report for project

Comments

@lang710
Copy link
Contributor

lang710 commented Jun 20, 2019

Ⅰ. Issue Description

when we create a container, there are no strict restrictions on the name format. I think we should improve it.

Ⅱ. Describe what happened

Example:

root@compatibility:~# pouch run --name new:invalid busybox top
root@compatibility:~# pouch ps
root@compatibility:~# Name           ID       Status         Created         Image            Runtime
new:invalid   9e1627   Up 5 seconds    4 seconds ago   busybox:latest   runc

Ⅲ. Describe what you expected to happen

There should be an Error response from daemon.
Actually, container name (new:invalid), only [a-zA-Z0-9][a-zA-Z0-9_.-] should be allowed.

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

I think the format of the input of all instructions' parameters should be strictly limited.

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project
Projects
None yet
Development

No branches or pull requests

3 participants