-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: create container with invalid name #2928
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2928 +/- ##
==========================================
- Coverage 68.18% 68.07% -0.12%
==========================================
Files 291 291
Lines 18339 18341 +2
==========================================
- Hits 12505 12486 -19
- Misses 4376 4390 +14
- Partials 1458 1465 +7
|
lang710
changed the title
bugfix: create contaienr with invalid name
bugfix: create container with invalid name
Jun 24, 2019
LGTM |
zhuangqh
reviewed
Jun 27, 2019
Signed-off-by: Lang Chi <21860405@zju.edu.cn>
ZYecho
reviewed
Jul 4, 2019
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lang Chi 21860405@zju.edu.cn
Ⅰ. Describe what this PR did
bugfix: create contaienr with invalid name
Ⅱ. Does this pull request fix one issue?
#2918
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Added.
Ⅳ. Describe how to verify it
root@compatibility:~/go/src/github.com/alibaba/pouch# pouch create --name new:invalid busybox
Error: failed to create container: {"message":"Invalid container name (new:invalid), only [a-zA-Z0-9][a-zA-Z0-9_.-] are allowed"}
Ⅴ. Special notes for reviews