feature: error stream for cri stream server #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaoZengzeng
force-pushed
the
error-stream
branch
from
01577c4
to
dc1e056
Compare
Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>
YaoZengzeng
force-pushed
the
error-stream
branch
from
dc1e056
to
5d979ab
Compare
Codecov Report
@@ Coverage Diff @@
## master #1007 +/- ##
=======================================
Coverage 13.67% 13.67%
=======================================
Files 124 124
Lines 8395 8395
=======================================
Hits 1148 1148
Misses 7148 7148
Partials 99 99
Continue to review full report at Codecov.
|
|
@allencloud PTAL |
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng yaozengzeng@zju.edu.cn
Ⅰ. Describe what this PR did
With this PR, we could get error if stream server handle exec or attach failed.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews