-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add snapshotter info into container json #1130
feature: add snapshotter info into container json #1130
Conversation
In fact, i am not sure whether this PR match your requirement, @yyb196 can you pls review this PR and give me some advice? |
apis/swagger.yml
Outdated
@@ -2808,8 +2808,8 @@ definitions: | |||
x-nullable: true | |||
Config: | |||
$ref: "#/definitions/ContainerConfig" | |||
GraphDriver: | |||
$ref: "#/definitions/GraphDriverData" | |||
Snapshotter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if removing GraphDriver is reasonable, since it will break the compatibility of API. WDYT? @yyb196
Codecov Report
@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
- Coverage 15.62% 15.61% -0.01%
==========================================
Files 172 172
Lines 9672 9674 +2
==========================================
Hits 1511 1511
- Misses 8052 8054 +2
Partials 109 109
|
a28252b
to
7ba7af5
Compare
Signed-off-by: Michael Wan <zirenwan@gmail.com>
7ba7af5
to
3048ff7
Compare
LGTM |
Signed-off-by: Michael Wan zirenwan@gmail.com
Ⅰ. Describe what this PR did
add snapshotter info into container json
since graphdriver has been replace by snapshotter, so i also rename the GraphDriver to Snapshotter in pouch
Ⅱ. Does this pull request fix one issue?
fixes #1011
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
now we has snapshotter info in container json
Ⅴ. Special notes for reviews