bugfix: fix flags name should be same #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this pr has conflict with #1132 , if one is merged, the other should be rebased. |
Codecov Report
@@ Coverage Diff @@
## master #1138 +/- ##
=======================================
Coverage 16.01% 16.01%
=======================================
Files 174 174
Lines 10042 10042
=======================================
Hits 1608 1608
Misses 8317 8317
Partials 117 117
|
|
it can be merged, @allencloud ,PTAL |
flag name and json field in daemon file should be consistent, cause we need check the valid and conflict in flags from two part. Signed-off-by: Ace-Tang <aceapril@126.com>
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flag name and json field in daemon file should be consistent,
cause we need check the valid and conflict in flags from two part.
Signed-off-by: Ace-Tang aceapril@126.com
Ⅰ. Describe what this PR did
flag name and json field in daemon file should be consistent,
cause we need check the valid and conflict in flags from two part.
for eg, this two part should have same name.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews