Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix a ineffectual assignment #1430

Merged

Conversation

idealhack
Copy link
Contributor

Ⅰ. Describe what this PR did

fix a ineffectual assignment

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@allencloud
Copy link
Collaborator

LGTM, thanks a lot for your contribution. I will merge this once the CI passes.

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 29, 2018
@codecov-io
Copy link

codecov-io commented May 29, 2018

Codecov Report

Merging #1430 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1430      +/-   ##
==========================================
- Coverage   38.78%   38.77%   -0.01%     
==========================================
  Files         250      250              
  Lines       16621    16621              
==========================================
- Hits         6446     6445       -1     
- Misses       9348     9349       +1     
  Partials      827      827
Impacted Files Coverage Δ
ctrd/image.go 83.43% <0%> (-1.85%) ⬇️
daemon/logger/jsonfile/utils.go 70% <0%> (ø) ⬆️
apis/server/utils.go 66.66% <0%> (+5.55%) ⬆️

@HusterWan HusterWan merged commit 52a540a into AliyunContainerService:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants