bugfix: bind an address for stream server #1520
Merged
+1,108
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng yaozengzeng@zju.edu.cn
Ⅰ. Describe what this PR did
The stream sever should bind an system interface, otherwise the URL it return will be like:
"http://:10010/exec/oM5ZZlm3"
So as mentioned in issue #1516 , we can't exec the pod from other nodes.
If the URL is lack of ip address, it will be localhost by default.
However the pod is not in the local node, so the local stream server will return 404.
Ⅱ. Does this pull request fix one issue?
#1516
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews