Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: alert the name of struct context to streamContext #1741

Merged

Conversation

starnop
Copy link
Contributor

@starnop starnop commented Jul 16, 2018

Signed-off-by: Starnop starnop@163.com

Ⅰ. Describe what this PR did

Alert the name remotecommand.context to remotecommand.streamContext in CRI Stream Manager.

Ⅱ. Does this pull request fix one issue?

None.

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

…n CRI Stream Manager

Signed-off-by: Starnop <starnop@163.com>
@codecov-io
Copy link

Codecov Report

Merging #1741 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1741      +/-   ##
==========================================
+ Coverage   14.13%   14.14%   +<.01%     
==========================================
  Files         281      281              
  Lines       56755    56755              
==========================================
+ Hits         8023     8026       +3     
+ Misses      47808    47804       -4     
- Partials      924      925       +1
Impacted Files Coverage Δ
cri/stream/remotecommand/httpstream.go 0% <0%> (ø) ⬆️
cri/stream/portforward/portforward.go 0% <0%> (ø) ⬆️
cri/stream/portforward/httpstream.go 0% <0%> (ø) ⬆️
cri/stream/remotecommand/attach.go 0% <0%> (ø) ⬆️
cri/stream/remotecommand/websocket.go 0% <0%> (ø) ⬆️
cri/stream/remotecommand/exec.go 0% <0%> (ø) ⬆️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
ctrd/image.go 79.2% <0%> (+2.47%) ⬆️

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 16, 2018
@allencloud allencloud merged commit 852541f into AliyunContainerService:master Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants