Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fast fail if the exit code of script is not zero #2049

Merged
merged 1 commit into from
Aug 4, 2018
Merged

bugfix: fast fail if the exit code of script is not zero #2049

merged 1 commit into from
Aug 4, 2018

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Aug 3, 2018

Signed-off-by: Wei Fu fhfuwei@163.com

Ⅰ. Describe what this PR did

Make CI happy

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

set -e in the bash script

Ⅳ. Describe how to verify it

Check the travis CI

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS size/S and removed size/XS labels Aug 3, 2018
Signed-off-by: Wei Fu <fhfuwei@163.com>
@fuweid fuweid changed the title bugfix bugfix: fast fail if the exit code of script is not zero Aug 3, 2018
@codecov-io
Copy link

Codecov Report

Merging #2049 into master will increase coverage by 5.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2049      +/-   ##
==========================================
+ Coverage   58.69%   63.97%   +5.27%     
==========================================
  Files         202      202              
  Lines       15491    15491              
==========================================
+ Hits         9093     9910     +817     
+ Misses       5298     4342     -956     
- Partials     1100     1239     +139
Flag Coverage Δ
#criv1alpha1test 33.7% <ø> (?)
#criv1alpha2test 34.28% <ø> (+0.02%) ⬆️
#integrationtest 38.58% <ø> (+0.07%) ⬆️
#unittest 22.16% <ø> (ø) ⬆️
Impacted Files Coverage Δ
apis/server/utils.go 61.9% <0%> (-4.77%) ⬇️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
ctrd/image.go 81.28% <0%> (+4.43%) ⬆️
cri/criservice.go 64.7% <0%> (+24.99%) ⬆️
cri/v1alpha1/cri_utils.go 82.32% <0%> (+33.03%) ⬆️
cri/v1alpha1/cri_wrapper.go 55.8% <0%> (+55.8%) ⬆️
cri/v1alpha1/cri.go 65.04% <0%> (+65.04%) ⬆️
cri/v1alpha1/server.go 79.84% <0%> (+79.84%) ⬆️
cri/v1alpha1/cri_stream.go 80% <0%> (+80%) ⬆️
cri/v1alpha1/service/cri.go 84.61% <0%> (+84.61%) ⬆️
... and 1 more

@fuweid fuweid requested review from rudyfly and sunyuan3 and removed request for rudyfly August 3, 2018 12:19
@sunyuan3 sunyuan3 merged commit f76d3bc into AliyunContainerService:master Aug 4, 2018
@fuweid fuweid deleted the bugfix_make_swagger_download_success branch August 31, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants