refactor: add more error information #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2055 +/- ##
==========================================
+ Coverage 59.05% 63.95% +4.89%
==========================================
Files 202 202
Lines 15494 15535 +41
==========================================
+ Hits 9150 9935 +785
+ Misses 5233 4360 -873
- Partials 1111 1240 +129
|
HusterWan
reviewed
Aug 7, 2018
| if err != nil { | ||
| return "", err | ||
| logrus.Errorf("failed to remount grpquota, mountpoint: (%s), stdout: (%s), stderr: (%s), exit: (%d), err: (%v)", |
There was a problem hiding this comment.
maybe errMsg := fmt.Sprintf("failed to remount grpquota, mountpoint: (%s), stdout: (%s), stderr: (%s), exit: (%d), err: (%v)", ...)
HusterWan
reviewed
Aug 7, 2018
storage/quota/grpquota.go
Outdated
| return mountPoint, err | ||
| logrus.Errorf("failed to setquota, stdout: (%s), stderr: (%s), exit: (%d), err: (%v)", | ||
| stdout, stderr, exit, err) | ||
| return mountPoint, errors.Wrapf(err, "failed to setquota, stdout: (%s), stderr: (%s), exit: (%d)") |
Add more error information in quota package. Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
|
lgtm |
pouchrobot
added
the
LGTM
fuweid
reviewed
Aug 7, 2018
| @@ -2321,7 +2321,9 @@ func (mgr *ContainerManager) setMountPointDiskQuota(ctx context.Context, c *Cont | |||
| } | |||
| err := quota.SetDiskQuota(mp.Source, size, qid) | |||
| if err != nil { | |||
| return err | |||
| // just ignore set disk quota fail | |||
There was a problem hiding this comment.
@rudyfly could we add reason at here, since there is no information about why we ignore the error?
There was a problem hiding this comment.
Because of the different environment problems, setting disk quota may be failed, in order to start container successfully, so we ignore the errors that cause by diskquota's tools.
This was referenced Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add more error information in quota package.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com