bugfix: umount rootfs when delete a container #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HusterWan
force-pushed
the
zr/umount-rootfs
branch
from
5ee9d7b to
085c29c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2196 +/- ##
=========================================
- Coverage 65.01% 64.9% -0.12%
=========================================
Files 208 208
Lines 16732 16734 +2
=========================================
- Hits 10879 10861 -18
- Misses 4504 4516 +12
- Partials 1349 1357 +8
|
allencloud
reviewed
Sep 4, 2018
daemon/mgr/container.go
Outdated
| } else { | ||
| // if creating the container by specify a rootfs, | ||
| // we should umount the mounted rootfs when delete it. | ||
| if err := mount.Unmount(c.BaseFS, 0); err != nil { |
There was a problem hiding this comment.
Please combine the else and if. I think that is better.
…nt the mounted rootfs when delete it. Signed-off-by: Michael Wan <zirenwan@gmail.com>
HusterWan
force-pushed
the
zr/umount-rootfs
branch
from
085c29c to
716caec
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan zirenwan@gmail.com
Ⅰ. Describe what this PR did
When using PouchContainer to replace the old container engine in Alibaba Group, we must take over the old running containers. Maybe somebody has known that we use d2p-migrator to convert those old containers to pouch containers
Since those old containers are not created by
pouchd, but taking over by specified a rootfs for container, the remove action is different from normal containers. We no need to delete the snapshot of container because old containers have no snapshots, then we also shouldumountthe rootfs when delete the container.Ⅱ. Does this pull request fix one issue?
None
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
It is difficult to imitate the situation of taking over containers, So i will add test case in
d2ptest.Ⅳ. Describe how to verify it
None
Ⅴ. Special notes for reviews
None