Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: allen.wang allen.wq@alipay.com
Ⅰ. Describe what this PR did
Consider to update container's hostname in a running container, It should join container namespace. So it imports package github.com/opencontainers/runc/libcontainer/nsenter to meet the requirement(about more implementation details refferring to Ⅳ. Describe how to verify it). Otherwise, It provides more register functions which can do more in container namespace.
Ⅱ. Does this pull request fix one issue?
fixes #2179
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
add test TestRunningContainerUpdateHostname and TestStoppedContainerUpdateHostname.
Ⅳ. Describe how to verify it
after doing update hostname, we can exec into container, and run command "hostname" to verify it.
Ⅴ. Special notes for reviews
It adds a package pkg/nsexec, which defines a function NsExec to join container namespace. It provides register functions map to allow do something in container namespace such as update hostname. It registers a reexec command called nsexec, which imports github.com/opencontainers/runc/libcontainer/nsenter to join container namespace by calling C code. Package pkg/nsexec executes new command to call pouchd nsexec.