feature: add cli attach command

[ZYecho]

Signed-off-by: zhangyue zy675793960@yeah.net

Ⅰ. Describe what this PR did

add attach cli command.

Ⅱ. Does this pull request fix one issue?

None

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)

Add proxy and term unit test.

Ⅳ. Describe how to verify it

1. run a container and detach from terminal
   $ pouch run -it --detach-keys="ctrl-d" busybox
2. get id or name
   $ pouch ps
3. attach it
   $ pouch attach --detach-keys="ctrl-x" busybox

Ⅴ. Special notes for reviews

inspired by docker attach impl and pr#2240

[allencloud]

Do we need to add some integration test to cover this command line's functionality? @ZYecho

[ZYecho]

Do we need to add some integration test to cover this command line's functionality? @ZYecho

I did't find the pattern about how do the cli command integration test, is there is a doc or code sample about that? could you help me with this? thank you

[allencloud]

the pattern about how do the cli command integration test, is there is a doc or code sample about that?

Yes, we have. Please check the documents here https://github.com/alibaba/pouch/blob/master/docs/test/test.md to get noticed of how to run local integration test. And an example is in https://github.com/alibaba/pouch/blob/master/test/cli_restart_test.go, you can see the restart command integration test there. @ZYecho

Please feel free to tell us if you have any questions. Thanks.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@401167e). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #2248   +/-   ##
=========================================
  Coverage          ?   69.04%           
=========================================
  Files             ?      279           
  Lines             ?    18491           
  Branches          ?        0           
=========================================
  Hits              ?    12768           
  Misses            ?     4272           
  Partials          ?     1451

Flag	Coverage Δ
#criv1alpha1test	31.26% <0%> (?)
#criv1alpha2test	35.28% <0%> (?)
#integrationtest	40.48% <0%> (?)
#nodee2etest	32.7% <0%> (?)
#unittest	26.76% <ø> (?)

Impacted Files	Coverage Δ
pkg/ioutils/readers.go	0% <0%> (ø)

[ZYecho]

the pattern about how do the cli command integration test, is there is a doc or code sample about that?

Yes, we have. Please check the documents here https://github.com/alibaba/pouch/blob/master/docs/test/test.md to get noticed of how to run local integration test. And an example is in https://github.com/alibaba/pouch/blob/master/test/cli_restart_test.go, you can see the restart command integration test there. @ZYecho

Please feel free to tell us if you have any questions. Thanks.

I add my integration test in test/cli_attach_test.go, but it seems not work. But when I test the attach command manually in the same way as code does, it works correctly. Could you help to review the test code? Thank you.

[ZYecho]

I’ve updated this pr, make integration test right , but CI blocked at criv1alpha2test, could you help to trigger the CI again? @allencloud , ping @fuweid for review to move on this pr either.

[CLAassistant]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

zhangyue seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[CLAassistant]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[ZYecho]

CI have passed, and fix some issue. @fuweid @allencloud PTAL, thanks.

[fuweid]

I think we should keep the same revision with existing docker package.

[ZYecho]

I have no idea how to keep it. could you give me some suggestions?

[fuweid]

For the current design, we have not supported the EscapeKeys yet in backend. Please check this.

[ZYecho]

just want to know, why the backend need work to support EscapeKeys?

[ZYecho]

close it temporarily