-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update the doc of deploy kubernetes with PouchContainer #2294
docs: update the doc of deploy kubernetes with PouchContainer #2294
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2294 +/- ##
=========================================
+ Coverage 66.74% 66.8% +0.05%
=========================================
Files 211 211
Lines 17205 17205
=========================================
+ Hits 11484 11493 +9
+ Misses 4316 4309 -7
+ Partials 1405 1403 -2
|
757b6a7
to
8b2c32a
Compare
@@ -2,19 +2,18 @@ | |||
|
|||
Updated: 2018.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about removing this line? @starnop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated! ^_^
Why has containerd's address changed? I think it is a big incompatibility there when deployment of kubernetes. @starnop |
@allencloud And Kubernetes update the cadvisor ,that's where the difference comes in: |
8b2c32a
to
bec89aa
Compare
bec89aa
to
d83f56d
Compare
Signed-off-by: Starnop <starnop@163.com>
d83f56d
to
f706e01
Compare
LGTM |
Signed-off-by: Starnop starnop@163.com
Ⅰ. Describe what this PR did
After verification, our documentation is not enough for users to quickly build the environment. Now we update the items as follows:
CONTAINERD_ADDR
Ⅱ. Does this pull request fix one issue?
None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
just docs.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
About more info about kubeadm/kubelet , please refer to:
kubernetes/kubeadm#822
https://v1-11.docs.kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-init/