Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change flags from --ports to --publish #2478

Merged
merged 1 commit into from
Nov 21, 2018

Conversation

cpaasarch
Copy link
Contributor

Ⅰ. Describe what this PR did

pouch have a flags --ports but in docker the flags is --publish.so I want to change --ports to --publish

Ⅱ. Does this pull request fix one issue?

no

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no. only change a flags .and I Install the rpm package local , then tests for the feature.

Ⅳ. Describe how to verify it

Step1: build and install
Step2: pouch run --help check the flags

Ⅴ. Special notes for reviews

shlallen

@codecov
Copy link

codecov bot commented Nov 21, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@4d421ec). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2478   +/-   ##
=========================================
  Coverage          ?   68.79%           
=========================================
  Files             ?      277           
  Lines             ?    18330           
  Branches          ?        0           
=========================================
  Hits              ?    12610           
  Misses            ?     4279           
  Partials          ?     1441
Flag Coverage Δ
#criv1alpha1test 31.44% <ø> (?)
#criv1alpha2test 35.78% <ø> (?)
#integrationtest 40.35% <ø> (?)
#nodee2etest 32.89% <ø> (?)
#unittest 26.69% <ø> (?)

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @cpaasarch
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2018

CLA assistant check
All committers have signed the CLA.

@fuweid
Copy link
Contributor

fuweid commented Nov 21, 2018

@cpaasarch could you use git commit -s --amend and repush your branch to sign your work? Thanks

More detail is here https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md#sign-your-work

@allencloud
Copy link
Collaborator

LGTM, but still wait for the CI to finish.

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Nov 21, 2018
Signed-off-by: cpaasarch <yaofang.zjl@alibaba-inc.com>
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants