-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change flags from --ports to --publish #2478
change flags from --ports to --publish #2478
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2478 +/- ##
=========================================
Coverage ? 68.79%
=========================================
Files ? 277
Lines ? 18330
Branches ? 0
=========================================
Hits ? 12610
Misses ? 4279
Partials ? 1441
|
We found this is your first time to contribute to Pouch, @cpaasarch |
@cpaasarch could you use More detail is here https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md#sign-your-work |
LGTM, but still wait for the CI to finish. |
5f8ae43
to
a1450d8
Compare
Signed-off-by: cpaasarch <yaofang.zjl@alibaba-inc.com>
a1450d8
to
a4c23fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
pouch have a flags --ports but in docker the flags is --publish.so I want to change --ports to --publish
Ⅱ. Does this pull request fix one issue?
no
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
no. only change a flags .and I Install the rpm package local , then tests for the feature.
Ⅳ. Describe how to verify it
Step1: build and install
Step2: pouch run --help check the flags
Ⅴ. Special notes for reviews
shlallen