Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update the existing tag image case #2547

Merged
merged 1 commit into from
Dec 10, 2018
Merged

test: update the existing tag image case #2547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 26 additions & 12 deletions test/api_image_tag_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func (suite *APIImageTagSuite) SetUpTest(c *check.C) {
// TestImageTagCreateWithTagOK tests OK.
func (suite *APIImageTagSuite) TestImageTagCreateWithTagOK(c *check.C) {
repo, tag := "localhost:5000/testimagetagok/pouch", "0.5.0"
resp, err := suite.sendRequest(busyboxImage, repo, tag)
resp, err := suite.doTag(busyboxImage, repo, tag)
c.Assert(err, check.IsNil)
CheckRespStatus(c, resp, 201)

Expand All @@ -42,7 +42,7 @@ func (suite *APIImageTagSuite) TestImageTagCreateWithTagOK(c *check.C) {
// TestImageTagCreateUsingDefaultTagOK tests OK.
func (suite *APIImageTagSuite) TestImageTagCreateUsingDefaultTagOK(c *check.C) {
repo, tag := "localhost:5000/testimagetagok/pouch", "latest"
resp, err := suite.sendRequest(busyboxImage, repo, tag)
resp, err := suite.doTag(busyboxImage, repo, tag)
c.Assert(err, check.IsNil)
CheckRespStatus(c, resp, 201)

Expand All @@ -54,7 +54,7 @@ func (suite *APIImageTagSuite) TestImageTagCreateUsingDefaultTagOK(c *check.C) {
// TestImageTagUsingNoFoundSourceImage tests fail.
func (suite *APIImageTagSuite) TestImageTagUsingNoFoundSourceImage(c *check.C) {
repo, tag := "image_test_using_no_found_source_image", "latest"
resp, err := suite.sendRequest("image_test_ghost_image", repo, tag)
resp, err := suite.doTag("image_test_ghost_image", repo, tag)
c.Assert(err, check.IsNil)
CheckRespStatus(c, resp, 404)
}
Expand All @@ -66,33 +66,47 @@ func (suite *APIImageTagSuite) TestImageTagFailToOverrideExistingPrimaryReferenc
command.PouchRun("pull", tagRef).Assert(c, icmd.Success)
defer DelImageForceOk(c, tagRef)

resp, err := suite.sendRequest(busyboxImage, repo, tag)
resp, err := suite.doTag(busyboxImage, repo, tag)
c.Assert(err, check.IsNil)
CheckRespStatus(c, resp, 400)
}

// TestImageTagFailToOverrideExistingTag tests fail.
func (suite *APIImageTagSuite) TestImageTagFailToOverrideExistingTag(c *check.C) {
repo, tag := "registry.hub.docker.com/library/busybox", "1.25"
repo, tag := "localhost:5000/shouldnotoverridetag", "1.0"
tagRef := fmt.Sprintf("%s:%s", repo, tag)
command.PouchRun("pull", tagRef).Assert(c, icmd.Success)
defer DelImageForceOk(c, tagRef)

resp, err := suite.sendRequest(busyboxImage, repo, tag)
c.Assert(err, check.IsNil)
CheckRespStatus(c, resp, 400)
// create valid tag
{
command.PouchRun("pull", busyboxImage).Assert(c, icmd.Success)

resp, err := suite.doTag(busyboxImage, repo, tag)
c.Assert(err, check.IsNil)
CheckRespStatus(c, resp, 201)
defer DelImageForceOk(c, tagRef)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why delete tagRef image？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tagRef image is created by the case. If we don't delete it, re-run this case will fail. It just is used to clean up.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the busyboxImage also will be remain, dont need to delele it？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

busyboxImage is created for the case suite and basically, all suites are related to this image. Therefore, we don't need to delete it.

}

// override existing tag
{
command.PouchRun("pull", busyboxImage125).Assert(c, icmd.Success)
defer DelImageForceOk(c, busyboxImage125)

resp, err := suite.doTag(busyboxImage125, repo, tag)
c.Assert(err, check.IsNil)
CheckRespStatus(c, resp, 400)
}
}

// TestImageTagFailToUseSha256AsName tests fail.
func (suite *APIImageTagSuite) TestImageTagFailToUseSha256AsName(c *check.C) {
repo, tag := "localhost:5000/sha256", "1.25"

resp, err := suite.sendRequest(busyboxImage, repo, tag)
resp, err := suite.doTag(busyboxImage, repo, tag)
c.Assert(err, check.IsNil)
CheckRespStatus(c, resp, 400)
}

func (suite *APIImageTagSuite) sendRequest(source, repo, tag string) (*http.Response, error) {
func (suite *APIImageTagSuite) doTag(source, repo, tag string) (*http.Response, error) {
q := url.Values{}
q.Set("repo", repo)
q.Set("tag", tag)
Expand Down