-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refact travis-ci #2673
test: refact travis-ci #2673
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2673 +/- ##
==========================================
- Coverage 69.32% 68.06% -1.26%
==========================================
Files 285 278 -7
Lines 18959 18030 -929
==========================================
- Hits 13144 12273 -871
- Misses 4346 4388 +42
+ Partials 1469 1369 -100
|
521ab6a
to
1bde518
Compare
33e8e87
to
050a7e7
Compare
@@ -13,4 +13,3 @@ coverage.txt | |||
.DS_Store | |||
bin/ | |||
coverage/ | |||
install/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @houstar just curiosity, why we ignore install
folder here?
make | ||
|
||
cp "${cmd}" /usr/local/bin | ||
wget "https://${OSS_BUCKET}.${OSS_ENDPOINT}/pouch-test/ubuntu/nsenter-2.24.1" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just reminder, if someone wants to run the script without nsenter binary, it might fail.
however, we can install nsenter manually to let the script work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nsenter is public in aliyun oss, so everyone can get it.
13b0ee5
to
6d91a85
Compare
PTAL @fuweid @allencloud |
6d91a85
to
30dc31a
Compare
refact travis-ci, make it run faster. 1. remove CRI v1alpha1 test 2. split the integration into multiple parts, let them run together, because the limit of travis ci jobs, we only can split four parts. 3. update travis-ci os version to ubuntu-16.04 xenial, because in this version, we can use apt-get to install criu, instead of building it by ourself, it can reduce the setup time. 4. I have built `nsenter` and upload to aliyun oss storage server, so only download it instead of building it every time. Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
30dc31a
to
9549ab6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
refact travis-ci, make it run faster.
because the limit of travis ci jobs, we only can split four parts.
because in this version, we can use apt-get to install criu, instead of
building it by ourself, it can reduce the setup time.
nsenter
and upload to aliyun oss storage server,so only download it instead of building it every time.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
refact test
Ⅳ. Describe how to verify it
ci pass
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com