Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refact travis-ci #2673

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Jan 16, 2019

Ⅰ. Describe what this PR did

refact travis-ci, make it run faster.

  1. remove CRI v1alpha1 test
  2. split the integration into multiple parts, let them run together,
    because the limit of travis ci jobs, we only can split four parts.
  3. update travis-ci os version to ubuntu-16.04 xenial,
    because in this version, we can use apt-get to install criu, instead of
    building it by ourself, it can reduce the setup time.
  4. I have built nsenter and upload to aliyun oss storage server,
    so only download it instead of building it every time.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

refact test

Ⅳ. Describe how to verify it

ci pass

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #2673 into master will decrease coverage by 1.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2673      +/-   ##
==========================================
- Coverage   69.32%   68.06%   -1.26%     
==========================================
  Files         285      278       -7     
  Lines       18959    18030     -929     
==========================================
- Hits        13144    12273     -871     
- Misses       4346     4388      +42     
+ Partials     1469     1369     -100
Flag Coverage Δ
#criv1alpha1test ?
#criv1alpha2_test 39.33% <ø> (?)
#criv1alpha2test ?
#integration_test_0 36.48% <ø> (?)
#integration_test_1 35.27% <ø> (?)
#integration_test_2 36.64% <ø> (?)
#integration_test_3 35.02% <ø> (?)
#integrationtest ?
#node_e2e_test 35.17% <ø> (?)
#nodee2etest ?
#unittest 27.36% <ø> (+0.4%) ⬆️
Impacted Files Coverage Δ
cri/criservice.go 34.93% <0%> (-21.69%) ⬇️
daemon/config/config.go 51.58% <0%> (-14.63%) ⬇️
daemon/mgr/spec_linux.go 69.17% <0%> (-9.56%) ⬇️
pkg/streams/utils.go 82.14% <0%> (-9.53%) ⬇️
daemon/mgr/container.go 50.3% <0%> (-8.65%) ⬇️
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
daemon/mgr/spec.go 65.38% <0%> (-1.29%) ⬇️
cri/v1alpha2/cri.go 71.64% <0%> (-0.5%) ⬇️
cri/v1alpha1/cri_utils.go
cri/v1alpha1/service/cri.go
... and 13 more

@rudyfly rudyfly requested review from fuweid and allencloud January 17, 2019 11:06
@rudyfly rudyfly force-pushed the test_run_faster branch 4 times, most recently from 33e8e87 to 050a7e7 Compare January 18, 2019 06:56
@@ -13,4 +13,3 @@ coverage.txt
.DS_Store
bin/
coverage/
install/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @houstar just curiosity, why we ignore install folder here?

.travis.yml Outdated Show resolved Hide resolved
hack/install/config.sh Outdated Show resolved Hide resolved
make

cp "${cmd}" /usr/local/bin
wget "https://${OSS_BUCKET}.${OSS_ENDPOINT}/pouch-test/ubuntu/nsenter-2.24.1" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just reminder, if someone wants to run the script without nsenter binary, it might fail.

however, we can install nsenter manually to let the script work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nsenter is public in aliyun oss, so everyone can get it.

travis_ci.sh Outdated Show resolved Hide resolved
travis_ci.sh Outdated Show resolved Hide resolved
travis_ci.sh Outdated Show resolved Hide resolved
@rudyfly rudyfly force-pushed the test_run_faster branch 2 times, most recently from 13b0ee5 to 6d91a85 Compare January 21, 2019 11:34
@rudyfly
Copy link
Collaborator Author

rudyfly commented Jan 22, 2019

PTAL @fuweid @allencloud

travis_ci.sh Outdated Show resolved Hide resolved
refact travis-ci, make it run faster.

1. remove CRI v1alpha1 test
2. split the integration into multiple parts, let them run together,
because the limit of travis ci jobs, we only can split four parts.
3. update travis-ci os version to ubuntu-16.04 xenial,
because in this version, we can use apt-get to install criu, instead of
building it by ourself, it can reduce the setup time.
4. I have built `nsenter` and upload to aliyun oss storage server,
so only download it instead of building it every time.

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
Copy link
Contributor

@zhuangqh zhuangqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants