Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add doc to describe how to use pouch run --log-driver #2677

Merged
merged 1 commit into from
Jan 25, 2019
Merged

docs: add doc to describe how to use pouch run --log-driver #2677

merged 1 commit into from
Jan 25, 2019

Conversation

hellolijj
Copy link
Contributor

Ⅰ. Describe what this PR did

add doc to describe how to use pouch run --log-driver

Ⅱ. Does this pull request fix one issue?

[help wanted][doc] add doc to describe how to use pouch run --log-driver

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Jan 20, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request head (dev@48290ec). Click here to learn what that means.
The diff coverage is n/a.

@pouchrobot pouchrobot added areas/docs areas/log kind/question all questions or confusion about this project size/S labels Jan 20, 2019
@fuweid
Copy link
Contributor

fuweid commented Jan 21, 2019

ping @hellolijj

something wrong here:

/docs/features/pouch_with_log_driver.md:12: MD012 Multiple consecutive blank lines
./docs/features/pouch_with_log_driver.md:35: MD031 Fenced code blocks should be surrounded by blank lines

A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md
Exited with code 123

@hellolijj hellolijj force-pushed the dev branch 2 times, most recently from e40f82d to fa19a82 Compare January 22, 2019 03:03
fuweid
fuweid suggested changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use git commit -s --amend --no-edit and repush again. thanks

docs/features/pouch_with_log_driver.md Outdated
You can view the type of log driver by following commands

```
pouch info | grep 'Logging Driver'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about using $ before the command? it can make the doc readable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah 😄

docs/features/pouch_with_log_driver.md Outdated

You can view the default log driver for running containers by following commands

pouch inspect 09092c -f {{.HostConfig.LogConfig}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this line since the following script show us. WDYT?

@hellolijj hellolijj force-pushed the dev branch 3 times, most recently from 8e23608 to 81e11ae Compare January 23, 2019 07:30
@pouchrobot pouchrobot added size/M and removed size/S labels Jan 23, 2019
@hellolijj
docs: add doc to describe how to use pouch run --log-driver
48290ec 
Signed-off-by: Junjun Li <junjunli666@gmail.com>
fuweid
fuweid approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit a86badc into AliyunContainerService:master Jan 25, 2019
@fuweid fuweid mentioned this pull request Jan 25, 2019
Closed
@pouchrobot pouchrobot mentioned this pull request Jan 25, 2019
Closed
@weekly-digest weekly-digest bot mentioned this pull request Jan 27, 2019
Closed
@pouchrobot pouchrobot mentioned this pull request Feb 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
areas/docs areas/log kind/question all questions or confusion about this project size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellolijj @fuweid @pouchrobot