Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update container state according to containerd events #2680

Merged

Conversation

zhuangqh
Copy link
Contributor

Signed-off-by: zhuangqh zhuangqhc@gmail.com

Ⅰ. Describe what this PR did

Update container state according to containerd events, such as OOM.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #2680 into master will increase coverage by 1.7%.
The diff coverage is 79.31%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2680     +/-   ##
=========================================
+ Coverage   67.48%   69.18%   +1.7%     
=========================================
  Files         278      278             
  Lines       17404    17432     +28     
=========================================
+ Hits        11745    12061    +316     
+ Misses       4340     4044    -296     
- Partials     1319     1327      +8
Flag Coverage Δ
#criv1alpha2_test 39.1% <41.37%> (-0.11%) ⬇️
#integration_test_0 36.28% <41.37%> (-0.03%) ⬇️
#integration_test_1 35.19% <41.37%> (ø) ⬆️
#integration_test_2 36.65% <79.31%> (+27.32%) ⬆️
#integration_test_3 35.1% <41.37%> (-0.02%) ⬇️
#node_e2e_test 35.01% <41.37%> (-0.15%) ⬇️
#unittest 27.38% <0%> (-0.05%) ⬇️
Impacted Files Coverage Δ
daemon/mgr/container_state.go 92.23% <100%> (+0.74%) ⬆️
daemon/mgr/container.go 59.24% <100%> (+0.63%) ⬆️
daemon/mgr/events.go 91.78% <68.42%> (-8.22%) ⬇️
pkg/meta/store.go 67.44% <0%> (-1.56%) ⬇️
daemon/mgr/container_utils.go 83.92% <0%> (-1.2%) ⬇️
ctrd/container.go 56.89% <0%> (-0.77%) ⬇️
cri/v1alpha2/cri.go 71.92% <0%> (ø) ⬆️
daemon/logger/jsonfile/utils.go 71.54% <0%> (+0.81%) ⬆️
daemon/mgr/container_stats.go 71.83% <0%> (+1.14%) ⬆️
... and 28 more

Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants