Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support update daemon with home-dir and snapshotter #2691

Conversation

wangforthinker
Copy link
Contributor

Ⅰ. Describe what this PR did

Support to update daemon config with home dir and snapshotter.

Ⅱ. Does this pull request fix one issue?

No.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

add test TestUpdateDaemonWithHomeDirAndSnapshotter.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #2691 into master will increase coverage by 1.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2691      +/-   ##
==========================================
+ Coverage   67.48%   69.12%   +1.64%     
==========================================
  Files         278      278              
  Lines       17404    17404              
==========================================
+ Hits        11745    12031     +286     
+ Misses       4340     4051     -289     
- Partials     1319     1322       +3
Flag Coverage Δ
#criv1alpha2_test 39.12% <ø> (-0.09%) ⬇️
#integration_test_0 36.26% <ø> (-0.06%) ⬇️
#integration_test_1 35.22% <ø> (+0.03%) ⬆️
#integration_test_2 36.57% <ø> (+27.23%) ⬆️
#integration_test_3 35.11% <ø> (-0.01%) ⬇️
#node_e2e_test 35.02% <ø> (-0.14%) ⬇️
#unittest 27.43% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pkg/meta/store.go 67.44% <0%> (-1.56%) ⬇️
daemon/mgr/container_utils.go 83.92% <0%> (-1.2%) ⬇️
ctrd/container.go 56.89% <0%> (-0.77%) ⬇️
cri/v1alpha2/cri.go 71.92% <0%> (ø) ⬆️
daemon/mgr/container.go 59.24% <0%> (+0.63%) ⬆️
daemon/mgr/container_stats.go 71.83% <0%> (+1.14%) ⬆️
daemon/mgr/image_store.go 97.74% <0%> (+1.5%) ⬆️
daemon/mgr/container_exec.go 79.67% <0%> (+1.62%) ⬆️
apis/server/container_bridge.go 90.28% <0%> (+1.71%) ⬆️
daemon/mgr/network.go 73.15% <0%> (+2.11%) ⬆️
... and 24 more

@wangforthinker
Copy link
Contributor Author

ping @rudyfly

Signed-off-by: allen.wang <allen.wq@alipay.com>
@rudyfly
Copy link
Collaborator

rudyfly commented Jan 29, 2019

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jan 29, 2019
@rudyfly rudyfly merged commit a1dc96c into AliyunContainerService:master Jan 29, 2019
@wangforthinker wangforthinker deleted the feature/support-update-snapshotter-and-home branch January 29, 2019 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants