Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: update blkio device's read/write Bps/IOps #2708

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

zjumoon01
Copy link
Contributor

Support update limit of block device, including read/write
bps/iops.

fix #2509

This patch is rebased from @houstar .
related: #2563

Signed-off-by: Wang Rui baijia.wr@antfin.com
Signed-off-by: Leno Hou lenohou@gmail.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #2708 into master will decrease coverage by 0.03%.
The diff coverage is 51.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2708      +/-   ##
==========================================
- Coverage   69.32%   69.28%   -0.04%     
==========================================
  Files         278      278              
  Lines       17462    17486      +24     
==========================================
+ Hits        12105    12116      +11     
- Misses       4027     4033       +6     
- Partials     1330     1337       +7
Flag Coverage Δ
#criv1alpha2_test 39.61% <40.74%> (+0.02%) ⬆️
#integration_test_0 36.34% <51.85%> (+0.01%) ⬆️
#integration_test_1 35.21% <24.07%> (+0.05%) ⬆️
#integration_test_2 36.6% <24.07%> (+0.39%) ⬆️
#integration_test_3 35.01% <24.07%> (-0.09%) ⬇️
#node_e2e_test 35.08% <24.07%> (+0.02%) ⬆️
#unittest 27.35% <0%> (-0.05%) ⬇️
Impacted Files Coverage Δ
daemon/mgr/container.go 59.21% <0%> (-0.29%) ⬇️
daemon/mgr/spec_linux.go 78.92% <100%> (+1.62%) ⬆️
ctrd/utils.go 82.35% <56.09%> (-17.65%) ⬇️
daemon/mgr/events.go 89.04% <0%> (-2.74%) ⬇️
ctrd/client.go 64.04% <0%> (-1.69%) ⬇️
cri/v1alpha2/cri.go 72.17% <0%> (+0.25%) ⬆️
ctrd/container.go 58.04% <0%> (+0.76%) ⬆️

pkg/utils/resource.go Outdated Show resolved Hide resolved
@allencloud
Copy link
Collaborator

CI fails with golint error:

pkg/utils/resource.go:11:1:warning: comment on exported function GetWeightDevice should be of the form "GetWeightDevice ..." (golint)
pkg/utils/resource.go:32:1:warning: comment on exported function GetThrottleDevice should be of the form "GetThrottleDevice ..." (golint)

PTAL @zjumoon01

ctrd/utils.go Outdated Show resolved Hide resolved
Support update limit of block device, including read/write
bps/iops.

Signed-off-by: Wang Rui <baijia.wr@antfin.com>
Signed-off-by: Leno Hou <lenohou@gmail.com>
@HusterWan
Copy link
Contributor

LGTM, wait for the ci pass

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Feb 14, 2019
@HusterWan HusterWan merged commit 5e410b5 into AliyunContainerService:master Feb 14, 2019
@zjumoon01 zjumoon01 deleted the new-updateblkio branch February 14, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Support update container's device io limit
4 participants