-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: update blkio device's read/write Bps/IOps #2708
Merged
HusterWan
merged 1 commit into
AliyunContainerService:master
from
zjumoon01:new-updateblkio
Feb 14, 2019
Merged
feature: update blkio device's read/write Bps/IOps #2708
HusterWan
merged 1 commit into
AliyunContainerService:master
from
zjumoon01:new-updateblkio
Feb 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2708 +/- ##
==========================================
- Coverage 69.32% 69.28% -0.04%
==========================================
Files 278 278
Lines 17462 17486 +24
==========================================
+ Hits 12105 12116 +11
- Misses 4027 4033 +6
- Partials 1330 1337 +7
|
HusterWan
reviewed
Feb 12, 2019
CI fails with golint error:
PTAL @zjumoon01 |
zjumoon01
force-pushed
the
new-updateblkio
branch
from
February 13, 2019 12:44
fb382c3
to
b4b860b
Compare
HusterWan
reviewed
Feb 14, 2019
Support update limit of block device, including read/write bps/iops. Signed-off-by: Wang Rui <baijia.wr@antfin.com> Signed-off-by: Leno Hou <lenohou@gmail.com>
zjumoon01
force-pushed
the
new-updateblkio
branch
from
February 14, 2019 03:57
b4b860b
to
d667e7c
Compare
LGTM, wait for the ci pass |
pouchrobot
added
the
LGTM
one maintainer or community participant agrees to merge the pull reuqest.
label
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support update limit of block device, including read/write
bps/iops.
fix #2509
This patch is rebased from @houstar .
related: #2563
Signed-off-by: Wang Rui baijia.wr@antfin.com
Signed-off-by: Leno Hou lenohou@gmail.com
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews