Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix can't set quota with ".*" #2728

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Feb 28, 2019

Ⅰ. Describe what this PR did

fix can't set quota with ".*", and haven't set quota id.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #2728 into master will decrease coverage by 0.01%.
The diff coverage is 46.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2728      +/-   ##
==========================================
- Coverage   69.28%   69.26%   -0.02%     
==========================================
  Files         278      278              
  Lines       17424    17442      +18     
==========================================
+ Hits        12072    12081       +9     
- Misses       4024     4032       +8     
- Partials     1328     1329       +1
Flag Coverage Δ
#criv1alpha2_test 39.48% <46.47%> (+0.03%) ⬆️
#integration_test_0 36.59% <16.9%> (-0.05%) ⬇️
#integration_test_1 35.53% <16.9%> (+0.02%) ⬆️
#integration_test_2 36.6% <16.9%> (+0.02%) ⬆️
#integration_test_3 35.31% <16.9%> (-0.01%) ⬇️
#node_e2e_test 35.28% <16.9%> (ø) ⬆️
#unittest 28.44% <0%> (+0.89%) ⬆️
Impacted Files Coverage Δ
storage/quota/quota.go 10.64% <ø> (-2.81%) ⬇️
daemon/mgr/container_storage.go 60.73% <46.47%> (+0.39%) ⬆️
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
ctrd/container.go 56.51% <0%> (-0.39%) ⬇️
daemon/mgr/container.go 60.58% <0%> (-0.21%) ⬇️
pkg/meta/store.go 68.99% <0%> (+1.55%) ⬆️
daemon/mgr/container_utils.go 83.52% <0%> (+1.7%) ⬆️

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XL labels Feb 28, 2019
fix can't set quota with ".*", and haven't set quota id.

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allencloud
Copy link
Collaborator

Just confirm,do we need to update the related documentation https://github.com/alibaba/pouch/blob/master/docs/features/pouch_with_diskquota.md ? @rudyfly @fuweid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants