Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix runc install dependencies to libseccomp-devel in centos #2735

Conversation

wangforthinker
Copy link
Contributor

Signed-off-by: allen.wang allen.wq@alipay.com

Ⅰ. Describe what this PR did

Fix runc install dependencies to libseccomp-devel in centos, reference to https://github.com/opencontainers/runc#building.

Ⅱ. Does this pull request fix one issue?

none.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: allen.wang <allen.wq@alipay.com>
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #2735 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2735      +/-   ##
=========================================
+ Coverage   69.33%   69.4%   +0.07%     
=========================================
  Files         278     278              
  Lines       17442   17442              
=========================================
+ Hits        12093   12106      +13     
+ Misses       4023    4016       -7     
+ Partials     1326    1320       -6
Flag Coverage Δ
#criv1alpha2_test 39.48% <ø> (ø) ⬆️
#integration_test_0 36.59% <ø> (-0.02%) ⬇️
#integration_test_1 35.53% <ø> (+0.04%) ⬆️
#integration_test_2 36.53% <ø> (-0.07%) ⬇️
#integration_test_3 35.39% <ø> (+0.12%) ⬆️
#node_e2e_test 35.44% <ø> (+0.09%) ⬆️
#unittest 28.44% <ø> (ø) ⬆️
Impacted Files Coverage Δ
ctrd/container.go 57.27% <0%> (-0.39%) ⬇️
daemon/mgr/container.go 60.79% <0%> (ø) ⬆️
cri/v1alpha2/cri.go 71.85% <0%> (+0.25%) ⬆️
daemon/mgr/spec_linux.go 79.85% <0%> (+1.07%) ⬆️
pkg/meta/store.go 68.99% <0%> (+1.55%) ⬆️
ctrd/client.go 65.73% <0%> (+1.68%) ⬆️
daemon/mgr/container_utils.go 83.52% <0%> (+1.7%) ⬆️
daemon/mgr/events.go 91.78% <0%> (+2.73%) ⬆️

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 12ea1e4 into AliyunContainerService:master Mar 5, 2019
@wangforthinker wangforthinker deleted the fix/runc_install_dependencies branch March 5, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants