daemon/mgr/image: update deadline for loading images #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2736 +/- ##
==========================================
+ Coverage 69.31% 69.37% +0.06%
==========================================
Files 278 278
Lines 17442 17442
==========================================
+ Hits 12090 12101 +11
+ Misses 4025 4018 -7
+ Partials 1327 1323 -4
|
|
Wait for ci pass |
Ace-Tang
reviewed
Mar 7, 2019
daemon/mgr/image.go
Outdated
| @@ -30,7 +30,9 @@ import ( | |||
| "github.com/sirupsen/logrus" | |||
| ) | |||
|
|
|||
| var deadlineLoadImagesAtBootup = time.Second * 10 | |||
| // NOTE: make it to 10 minutes because it will take long time to load the | |||
There was a problem hiding this comment.
Actually this is not overtime because of image, but the machine env, like load, or other thing, would you mind to change the comment? @fuweid
There was a problem hiding this comment.
yeah. it is one of reason. the biggest issue is high load in machine.
There was a problem hiding this comment.
Actually not vary accurately， also ok
PouchContainer will load all the images from containerd into memory. At the beginning, we assume that it can load it in 10 secs. But if the system has busy IO, it will take long time to load it, especially the more-layers and huge-size images. So update it from 10 secs to 10 mins. Signed-off-by: Wei Fu <fuweid89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wei Fu fuweid89@gmail.com
Ⅰ. Describe what this PR did
PouchContainer will load all the images from containerd into memory. At
the beginning, we assume that it can load it in 10 secs. But if the
system has busy IO, it will take long time to load it, especially the
more-layers and huge-size images. So update it from 10 secs to 10 mins.
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
no need.
Ⅳ. Describe how to verify it
CI
Ⅴ. Special notes for reviews