Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing details generated by swagger #2753

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

allencloud
Copy link
Collaborator

Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com

Ⅰ. Describe what this PR did

docs: add missing details generated by swagger

due to PR #2745 has missed this part.

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need.

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

none

Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #2753 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2753      +/-   ##
=========================================
- Coverage   69.37%   69.2%   -0.17%     
=========================================
  Files         277     277              
  Lines       17412   17615     +203     
=========================================
+ Hits        12080   12191     +111     
- Misses       4008    4086      +78     
- Partials     1324    1338      +14
Flag Coverage Δ
#criv1alpha2_test 39.35% <ø> (-0.02%) ⬇️
#integration_test_0 36.6% <ø> (+0.02%) ⬆️
#integration_test_1 35.77% <ø> (-0.06%) ⬇️
#integration_test_2 36.5% <ø> (+0.01%) ⬆️
#integration_test_3 35.47% <ø> (ø) ⬆️
#node_e2e_test 35.26% <ø> (+0.04%) ⬆️
#unittest 28.51% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pkg/streams/utils.go 82.14% <0%> (-9.53%) ⬇️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
daemon/mgr/container.go 60.12% <0%> (-0.63%) ⬇️
cri/v1alpha2/cri.go 71.63% <0%> (+0.38%) ⬆️
ctrd/container.go 56.74% <0%> (+0.53%) ⬆️
cri/ocicni/cni_manager.go 70.58% <0%> (+11.76%) ⬆️

Copy link
Contributor

@Ace-Tang Ace-Tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ace-Tang Ace-Tang merged commit 9df3f72 into AliyunContainerService:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants