Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add override default mount config test #2766

Merged
merged 1 commit into from
Mar 29, 2019
Merged

test: add override default mount config test #2766

merged 1 commit into from
Mar 29, 2019

Conversation

Ace-Tang
Copy link
Contributor

tests user defined bind should override default mount config

Signed-off-by: Ace-Tang aceapril@126.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

tests user defined bind should override default mount config

Signed-off-by: Ace-Tang <aceapril@126.com>
@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@572c732). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2766   +/-   ##
=========================================
  Coverage          ?   69.44%           
=========================================
  Files             ?      277           
  Lines             ?    17429           
  Branches          ?        0           
=========================================
  Hits              ?    12103           
  Misses            ?     4001           
  Partials          ?     1325
Flag Coverage Δ
#criv1alpha2_test 39.39% <ø> (?)
#integration_test_0 36.64% <ø> (?)
#integration_test_1 35.45% <ø> (?)
#integration_test_2 36.59% <ø> (?)
#integration_test_3 35.31% <ø> (?)
#node_e2e_test 35.23% <ø> (?)
#unittest 28.52% <ø> (?)

@Ace-Tang Ace-Tang changed the title strefactor: combine functions into one file test: add override default mount config test Mar 21, 2019
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants