Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: not save ExecIds to meta.json file #2777

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

HusterWan
Copy link
Contributor

Signed-off-by: Michael Wan zirenwan@gmail.com

Ⅰ. Describe what this PR did

The ExecIds are all stored in memory, so we no need to store them to the container meta.json file.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Michael Wan <zirenwan@gmail.com>
@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #2777 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2777      +/-   ##
==========================================
+ Coverage   69.32%   69.34%   +0.01%     
==========================================
  Files         277      277              
  Lines       17425    17425              
==========================================
+ Hits        12080    12083       +3     
+ Misses       4019     4011       -8     
- Partials     1326     1331       +5
Flag Coverage Δ
#criv1alpha2_test 39.38% <ø> (+0.03%) ⬆️
#integration_test_0 36.56% <ø> (-0.03%) ⬇️
#integration_test_1 35.75% <ø> (ø) ⬆️
#integration_test_2 36.55% <ø> (+0.03%) ⬆️
#integration_test_3 35.47% <ø> (ø) ⬆️
#node_e2e_test 35.3% <ø> (+0.01%) ⬆️
#unittest 28.53% <ø> (ø) ⬆️
Impacted Files Coverage Δ
daemon/mgr/container_types.go 72.85% <ø> (ø) ⬆️
pkg/meta/store.go 67.44% <0%> (-1.56%) ⬇️
daemon/mgr/container_utils.go 81.81% <0%> (-1.14%) ⬇️
ctrd/container.go 56.02% <0%> (+0.19%) ⬆️
pkg/streams/utils.go 89.28% <0%> (+7.14%) ⬆️

@pouchrobot pouchrobot added areas/test kind/bug This is bug report for project size/XS labels Mar 27, 2019
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit cc4be95 into AliyunContainerService:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/bug This is bug report for project size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants