Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroup: make cgroup-parent absolute path #2784

Merged
merged 1 commit into from
Mar 29, 2019
Merged

cgroup: make cgroup-parent absolute path #2784

merged 1 commit into from
Mar 29, 2019

Conversation

Ace-Tang
Copy link
Contributor

avoid get cgroup path like /sys/fs/cgroup/memory/system.slice/...
since if cgroup path is relative path, controller path get from
/proc/self/cgroup.

Signed-off-by: Ace-Tang aceapril@126.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

avoid get cgroup path like /sys/fs/cgroup/memory/system.slice/...
since if cgroup path is relative path, controller path get from
`/proc/self/cgroup`.

Signed-off-by: Ace-Tang <aceapril@126.com>
@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #2784 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2784      +/-   ##
==========================================
- Coverage   69.46%   69.35%   -0.12%     
==========================================
  Files         277      277              
  Lines       17425    17425              
==========================================
- Hits        12105    12085      -20     
- Misses       3998     4015      +17     
- Partials     1322     1325       +3
Flag Coverage Δ
#criv1alpha2_test 39.34% <100%> (-0.05%) ⬇️
#integration_test_0 36.65% <100%> (ø) ⬆️
#integration_test_1 35.41% <100%> (ø) ⬆️
#integration_test_2 36.49% <100%> (-0.06%) ⬇️
#integration_test_3 35.46% <100%> (+0.06%) ⬆️
#node_e2e_test 35.27% <100%> (-0.1%) ⬇️
#unittest 28.53% <0%> (ø) ⬆️
Impacted Files Coverage Δ
daemon/mgr/spec_linux.go 78.77% <100%> (-1.08%) ⬇️
pkg/streams/utils.go 82.14% <0%> (-7.15%) ⬇️
ctrd/container.go 55.83% <0%> (-1.34%) ⬇️
daemon/mgr/container.go 60.2% <0%> (-0.63%) ⬇️
cri/v1alpha2/cri.go 72.14% <0%> (-0.26%) ⬇️
ctrd/watch.go 83.09% <0%> (+5.63%) ⬆️

@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 29, 2019
@HusterWan HusterWan merged commit baf8555 into AliyunContainerService:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants