-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add Mountpoints in containers/json api #2816
feature: add Mountpoints in containers/json api #2816
Conversation
Signed-off-by: Michael Wan <zirenwan@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2816 +/- ##
==========================================
- Coverage 69.34% 69.32% -0.02%
==========================================
Files 278 278
Lines 17428 17432 +4
==========================================
Hits 12085 12085
- Misses 3994 3996 +2
- Partials 1349 1351 +2
|
@@ -173,6 +178,7 @@ func (s *Server) getContainers(ctx context.Context, rw http.ResponseWriter, req | |||
Labels: c.Config.Labels, | |||
HostConfig: c.HostConfig, | |||
NetworkSettings: netSettings, | |||
Mounts: mounts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW,in terms of compatibility, I compared pouchcontainer's returns struct and
moby's(https://github.com/moby/moby/blob/master/api/swagger.yaml#L3434-L3501), and found that we still miss:
Ports
State
SizeRw
SizeRootfs
Will all these missing fields affect your usecases? @wangforthinker @zjumoon01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no effect at the moment. But it is better to add missing filed in returns struct. @allencloud
LGTM |
Signed-off-by: Michael Wan zirenwan@gmail.com
Ⅰ. Describe what this PR did
add
MountPoint
in container body in apicontainers/json
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews