refactor: cri setup network before creating sandbox #2819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VM-like container required the network initialization before creating sandbox container. This order won't affect the runc container. Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2819 +/- ##
==========================================
- Coverage 69.34% 69.26% -0.08%
==========================================
Files 278 279 +1
Lines 17428 17533 +105
==========================================
+ Hits 12085 12145 +60
- Misses 3994 4026 +32
- Partials 1349 1362 +13
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
VM-like container required the network initialization before creating sandbox container. This order won't affect the runc container.
netns, which enable to directly specific the net namespace path in the OCI spec, and skip any network prepare job.Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
should act like before.
Ⅳ. Describe how to verify it
pass the CRI test
Ⅴ. Special notes for reviews
We managed the CNI netns life cycle by ourselves. There should not have any resource leaks.