bugfix: fix lease used by pouchd may be expired #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Wan <zirenwan@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2820 +/- ##
==========================================
- Coverage 69.34% 67.92% -1.43%
==========================================
Files 278 278
Lines 17428 17448 +20
==========================================
- Hits 12085 11851 -234
- Misses 3994 4247 +253
- Partials 1349 1350 +1
|
allencloud
reviewed
May 2, 2019
| @@ -86,8 +90,13 @@ func NewClient(opts ...ClientOpt) (APIClient, error) { | |||
| insecureRegistries: copts.insecureRegistries, | |||
| } | |||
|
|
|||
| lease, err := client.preparePouchdLease(copts.rpcAddr, copts.defaultns) | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to prepare a lease for pouchd") | |||
There was a problem hiding this comment.
why not to print the detailed err in the returned err? @HusterWan @fuweid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan zirenwan@gmail.com
Ⅰ. Describe what this PR did
In containerd 1.2.5
WithLeaseadd a default expire time, so when pouchd starting, it will got a lease with expire time, so the pouchd will got errors calling containerd API when the lease expired.So we create a named lease that is
pouchd.lease. when pouchd starting , we just fetch the named lease and make sure the lease do not have expire label.Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews