Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If restart pod sanbox, rewrite etc resolv.conf again. #2843

Conversation

wangforthinker
Copy link
Contributor

Ⅰ. Describe what this PR did

fix if restart pod sanbox container, sanbox /etc/resolv.conf will be restore to host /etc/resolv.conf.

Ⅱ. Does this pull request fix one issue?

None.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

none.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

…restore to host /etc/resolv.conf

Signed-off-by: allen.wang <allen.wq@alipay.com>
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #2843 into master will decrease coverage by 1.79%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2843     +/-   ##
========================================
- Coverage   69.09%   67.3%   -1.8%     
========================================
  Files         285     285             
  Lines       17844   17848      +4     
========================================
- Hits        12330   12013    -317     
- Misses       4114    4481    +367     
+ Partials     1400    1354     -46
Flag Coverage Δ
#criv1alpha2_test 39.05% <0%> (+0.04%) ⬆️
#integration_test_0 36.55% <0%> (-0.02%) ⬇️
#integration_test_1 ?
#integration_test_2 36.49% <0%> (+0.02%) ⬆️
#integration_test_3 35.46% <0%> (ø) ⬆️
#node_e2e_test 34.77% <0%> (-0.01%) ⬇️
#unittest 28.52% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
cri/v1alpha2/cri.go 69.22% <0%> (+0.15%) ⬆️
ctrd/image_commit.go 0% <0%> (-69.29%) ⬇️
daemon/mgr/container_commit.go 0% <0%> (-56.1%) ⬇️
daemon/mgr/container_checkpoint.go 54.21% <0%> (-14.46%) ⬇️
pkg/reference/def.go 77.77% <0%> (-11.12%) ⬇️
daemon/mgr/network_utils.go 30.43% <0%> (-10.87%) ⬇️
daemon/mgr/events.go 87.5% <0%> (-9.73%) ⬇️
apis/server/network_bridge.go 57.25% <0%> (-8.88%) ⬇️
daemon/mgr/container_exec.go 71.54% <0%> (-8.14%) ⬇️
apis/server/container_bridge.go 82.5% <0%> (-7.5%) ⬇️
... and 19 more

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cardyok cardyok requested a review from Novicei July 7, 2022 12:15
@Novicei Novicei closed this Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants