-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: search the images from specific registry #2850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2850 +/- ##
==========================================
- Coverage 69.09% 69.03% -0.07%
==========================================
Files 285 286 +1
Lines 17844 17889 +45
==========================================
+ Hits 12330 12349 +19
- Misses 4114 4130 +16
- Partials 1400 1410 +10
|
hellolijj
force-pushed
the
dev
branch
5 times, most recently
from
May 16, 2019 12:14
5d8f669
to
db756bd
Compare
ZYecho
reviewed
May 17, 2019
this is my first time to add a feature. i attend to accomplish it step by step. |
ZYecho
reviewed
May 19, 2019
ZYecho
reviewed
May 21, 2019
hellolijj
force-pushed
the
dev
branch
2 times, most recently
from
May 21, 2019 13:19
c6e57e2
to
a44a8fe
Compare
ZYecho
reviewed
May 22, 2019
@hellolijj any update? lack of integration test now. |
all right, i will add it today |
hellolijj
force-pushed
the
dev
branch
2 times, most recently
from
May 28, 2019 03:31
f71fa3b
to
faaf406
Compare
allencloud
changed the title
Search the images from specific registry
feature: search the images from specific registry
May 28, 2019
ZYecho
reviewed
May 28, 2019
ZYecho
reviewed
May 28, 2019
LGTM |
# Conflicts: # daemon/mgr/image.go
Thanks for your great work. @hellolijj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Junjun Li junjunli666@gmail.com
Ⅰ. Describe what this PR did
add feature: pouch support search the images from specific registry
Ⅱ. Does this pull request fix one issue?
[feature] pouch cli supports search image
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
pouch search nginx
pouch search nginx -r https://a.b.com
Ⅴ. Special notes for reviews
1、add parameters in
/images/search
api2、are these test cases reasonable?