feature: add container prune command #2856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2856 +/- ##
==========================================
+ Coverage 67.21% 67.23% +0.02%
==========================================
Files 291 293 +2
Lines 18238 18284 +46
==========================================
+ Hits 12258 12294 +36
- Misses 4525 4527 +2
- Partials 1455 1463 +8
|
hellolijj
force-pushed
the
dev-prune-container
branch
from
ad1204b to
ee355b8
Compare
hellolijj
commented
May 22, 2019
| continue | ||
| } | ||
|
|
||
| if c.SizeRw > 0 { |
There was a problem hiding this comment.
Here, I take c.SizeRw as reclaimed space. is it right?
ZYecho
reviewed
May 23, 2019
yeya24
reviewed
May 27, 2019
hellolijj
force-pushed
the
dev-prune-container
branch
from
0926c4d to
8e73f56
Compare
ZYecho
changed the title
ZYecho
reviewed
Jun 3, 2019
| } | ||
|
|
||
| // TestContainerPruneWork tests "pouch container prune" work. | ||
| func (suite *PouchContainerPruneSuite) TestContainerPruneWork(c *check.C) { |
There was a problem hiding this comment.
could we add a test case for filter usage?
There was a problem hiding this comment.
why only add invalid test case here？
hellolijj
force-pushed
the
dev-prune-container
branch
from
8e73f56 to
12931a1
Compare
hellolijj
force-pushed
the
dev-prune-container
branch
2 times, most recently
from
d896678 to
97fd21f
Compare
ZYecho
reviewed
Jun 10, 2019
| @@ -33,6 +33,11 @@ func (c *Container) IsRemoving() bool { | |||
| return c.State.Status == types.StatusRemoving | |||
| } | |||
|
|
|||
| // IsStopped returns container is stopped or not. | |||
| func (c *Container) IsStopped() bool { | |||
There was a problem hiding this comment.
just to confirm, does docker only delete stopped container?
hellolijj
force-pushed
the
dev-prune-container
branch
from
97fd21f to
5ad2d95
Compare
Signed-off-by: Junjun Li <junjunli666@gmail.com>
hellolijj
force-pushed
the
dev-prune-container
branch
from
5ad2d95 to
364fa0e
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Junjun Li junjunli666@gmail.com
Ⅰ. Describe what this PR did
add
pouch container prunecommandⅡ. Does this pull request fix one issue?
#2213
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews