-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: sort objects to solve out-of-order output #2862
Conversation
We found this is your first time to contribute to pouch, @yeya24 |
Codecov Report
@@ Coverage Diff @@
## master #2862 +/- ##
==========================================
- Coverage 69.09% 69.09% -0.01%
==========================================
Files 285 285
Lines 17844 17844
==========================================
- Hits 12330 12329 -1
+ Misses 4114 4113 -1
- Partials 1400 1402 +2
|
5e7e7be
to
d9b1531
Compare
08a6955
to
96eb44b
Compare
@ZYecho Hello, can you help me fix circle-ci failure? I don't know why these link is broken. Can you re-trigger this? |
I'm not sure I have the rights to re-trigger that, but you can re-push use |
Signed-off-by: yeya24 <yb532204897@gmail.com> add testcase for volume listing Signed-off-by: yeya24 <yb532204897@gmail.com>
3749c28
to
60005a7
Compare
LGTM |
Any updates for this PR? Otherwise I will close this. |
Close this. |
Signed-off-by: yeya24 yb532204897@gmail.com
Ⅰ. Describe what this PR did
It is a small enhancement. I found that some commands such as
pouch network ls
orpouch volume ls
will produce some outputs with different orders. We should sort these output in the code of cli as docker cli does.Here is an example with different output:
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews