-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: pouch run supports --env-file #2857 #2863
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2863 +/- ##
==========================================
- Coverage 69.09% 66.29% -2.81%
==========================================
Files 285 285
Lines 17844 17844
==========================================
- Hits 12330 11830 -500
- Misses 4114 4592 +478
- Partials 1400 1422 +22
|
We found this is your first time to contribute to pouch, @lang710 |
|
Signed-off-by: lang chi <21860405@zju.edu.cn>
Signed-off-by: lang chi <21860405@zju.edu.cn>
Thanks for your work. Could you please squash the commits into a single one and check the ci failures? @lang710 |
Ⅰ. Describe what this PR did
pouch run supports --env-file
Ⅱ. Does this pull request fix one issue?
fixes #2857
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
don't like
Ⅳ. Describe how to verify it
pouch run --env-file=/home/abc -d busybox top
b2f0df7176e9459441276c7470ad95ae701329b49ff2709344706316597ce639
[root@vm_centos pouch]# pouch exec b2f0df7176e9459441276c7470ad95ae701329b49ff2709344706316597ce639 env | grep env_var_name
env_var_name=another_value
Ⅴ. Special notes for reviews