test: modify the env test #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lang Chi <21860405@zju.edu.cn>
Codecov Report
@@ Coverage Diff @@
## master #2872 +/- ##
==========================================
- Coverage 69.09% 69.04% -0.06%
==========================================
Files 285 285
Lines 17844 17844
==========================================
- Hits 12330 12321 -9
- Misses 4114 4117 +3
- Partials 1400 1406 +6
|
fuweid
reviewed
May 29, 2019
| @@ -305,7 +305,7 @@ func (suite *PouchCreateSuite) TestCreateWithEnv(c *check.C) { | |||
| env3 := "TEST3" // should not in container's real env | |||
| env4 := "TEST4=a b" // valid | |||
| env5 := "TEST5=a=b" // valid | |||
| res := command.PouchRun("run", "-d", | |||
There was a problem hiding this comment.
I think this is "create" test, So I feel "create+start" is more suitable than "run".
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lang Chi 21860405@zju.edu.cn
Ⅰ. Describe what this PR did
Modify the env test in test/cli_create_test.go
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
No need!
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews