bugfix: removing image by ID should conflict with running container. #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If image is used by a running container and this image has another tag, there are two reference of this image. Remove the image by ID without "--force" will success that is unexpected. This patch will fix it. We should check if any containers using this image ID. And add tests. Signed-off-by: Wang Rui <baijia.wr@antfin.com>
Codecov Report
@@ Coverage Diff @@
## master #2927 +/- ##
==========================================
+ Coverage 66.78% 68.28% +1.49%
==========================================
Files 289 291 +2
Lines 18299 18334 +35
==========================================
+ Hits 12221 12519 +298
+ Misses 4645 4358 -287
- Partials 1433 1457 +24
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If image is used by a running container and this image has another tag,
there are two reference of this image. Remove the image by ID without
"--force" will success that is unexpected.
This patch will fix it. We should check if any containers using this
image ID. And add tests.
Signed-off-by: Wang Rui baijia.wr@antfin.com
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
step 1. Pull image registry.hub.docker.com/library/busybox:1.28
step 2. Tag this image to registry.hub.docker.com/library/busybox:tag2
step 3. Run a container with this image
step 4. Pouch rmi without "--force", the image will removed unexpected.
With this patch, it won't be successful in Step 4.
Ⅴ. Special notes for reviews