Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create time should in seconds instead of nano seconds #2955

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

yyb196
Copy link
Collaborator

@yyb196 yyb196 commented Jul 31, 2019

Signed-off-by: frankyang yyb196@gmail.com

Ⅰ. Describe what this PR did

when doing container list create time of every container should in seconds, or users who use docker as client to list containers will get the wrong create time. according to https://docs.docker.com/engine/api/v1.24/

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

test cases has been modified

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: frankyang <yyb196@gmail.com>
@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #2955 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2955      +/-   ##
==========================================
- Coverage   68.19%   68.14%   -0.05%     
==========================================
  Files         291      291              
  Lines       18351    18351              
==========================================
- Hits        12514    12506       -8     
- Misses       4382     4384       +2     
- Partials     1455     1461       +6
Flag Coverage Δ
#criv1alpha2_test 34.78% <0%> (-0.03%) ⬇️
#integration_test_0 36.11% <0%> (ø) ⬆️
#integration_test_1 35.49% <0%> (+0.02%) ⬆️
#integration_test_2 36.09% <100%> (-0.07%) ⬇️
#integration_test_3 35.54% <80%> (-0.02%) ⬇️
#node_e2e_test 34.22% <0%> (+0.01%) ⬆️
#unittest 27.95% <80%> (ø) ⬆️
Impacted Files Coverage Δ
daemon/mgr/container_types.go 71.32% <100%> (ø) ⬆️
apis/server/container_bridge.go 90.55% <100%> (ø) ⬆️
pkg/utils/timeutils.go 100% <100%> (ø) ⬆️
ctrd/watch.go 72.97% <0%> (-5.41%) ⬇️
pkg/system/system.go 68.57% <0%> (-2.86%) ⬇️
ctrd/container.go 53.18% <0%> (-0.75%) ⬇️
cri/v1alpha2/cri.go 64.34% <0%> (+0.25%) ⬆️

Copy link
Contributor

@zhuangqh zhuangqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants