-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: add commit for the version #2980
Merged
zhuangqh
merged 1 commit into
AliyunContainerService:master
from
fuweid:me-improve-version
Oct 14, 2019
Merged
Makefile: add commit for the version #2980
zhuangqh
merged 1 commit into
AliyunContainerService:master
from
fuweid:me-improve-version
Oct 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2980 +/- ##
==========================================
- Coverage 68.19% 68.08% -0.11%
==========================================
Files 291 291
Lines 18366 18366
==========================================
- Hits 12524 12504 -20
- Misses 4383 4396 +13
- Partials 1459 1466 +7
|
test fail, please repush |
There is flaky case. I will take look this and update soon. |
fuweid
changed the title
Makefile: add commit for the version
[WIP] Makefile: add commit for the version
Oct 11, 2019
Since kubernetes will use version in node list, v1.3.0 is too general and we cannot tell no thing. Based on this, we can set the last commit for the version. Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid
changed the title
[WIP] Makefile: add commit for the version
Makefile: add commit for the version
Oct 14, 2019
zhuangqh
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wei Fu fuweid89@gmail.com
Ⅰ. Describe what this PR did
Since kubernetes will use version in node list, v1.3.0 is too general
and we cannot tell no thing. Based on this, we can set the last commit
for the version.
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
no need
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews